Re: [RFC] Should "SHOW huge_pages" display the effective value "off" when the huge page is unavailable?

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [RFC] Should "SHOW huge_pages" display the effective value "off" when the huge page is unavailable?
Date: 2017-02-06 14:58:38
Message-ID: CAHGQGwFv7hg=-QpU1Y5Z2H8yAPMWJS5es5p+iJwXpJ9h1pmQpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 6, 2017 at 4:01 PM, Tsunakawa, Takayuki
<tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> Hello, all
>
> Could you give me your opinions on whether the SHOW command should display the effective value or the specified value for huge_pages? During the review of "Supporting huge_pages on Windows", which is now shifted to CommitFest 2017-3, Magnus gave me a comment that the huge_page variable should retain the value "try" when the huge page is not available on the machine and the server falls back to huge_page=off. The Linux version does so.
>
> I don't have a strong opinion on that, but I think a bit that it would be better to reflect the effective setting, i.e. SHOW displays huge_pages as off, not try.

Not sure if this is best way to do that, but I agree that it's helpful if
we can see whether the server actually uses huge page or not in
huge_page=try case.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-02-06 15:36:38 Re: [RFC] Should "SHOW huge_pages" display the effective value "off" when the huge page is unavailable?
Previous Message Aleksander Alekseev 2017-02-06 14:43:46 Re: SCRAM authentication, take three