| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add MERGE and VALUES statements to tab completion for PREPARE |
| Date: | 2025-11-21 06:33:00 |
| Message-ID: | CAHGQGwFen_z0_ebg8bS2cQ0YFTchxbgf6jhrfJNuhUqm=4b0Uw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 20, 2025 at 3:05 PM Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp> wrote:
>
> > Should we suggest "MERGE INTO" instead of just "MERGE",
> > since INTO always follows MERGE?
> >
> > Also, how about adding "TABLE" and "WITH" to the suggestions,
> > similar to the tab-completion for "COPY ("?
> > SELECT statement can be specified in the PREPARE command,
> > and it can start with SELECT, TABLE, or WITH [1].
>
> Agreed.
> I have updated the patch.
Thanks for the update!
The patch looks good to me. I made one small adjustment: the updated line
was a bit long, so I added a line break. I also revised the commit message.
The updated patch is attached. I'll go ahead and commit it.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-psql-Improve-tab-completion-for-PREPARE.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-11-21 06:55:37 | Re: Skipping schema changes in publication |
| Previous Message | Chao Li | 2025-11-21 06:26:25 | Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis |