Re: Add MERGE and VALUES statements to tab completion for PREPARE

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add MERGE and VALUES statements to tab completion for PREPARE
Date: 2025-11-23 14:05:50
Message-ID: CAHGQGwF_LXftqzj0=0xmCkx7nFxbEHW2wFDajTfB7f54HUGySQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 21, 2025 at 3:33 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Nov 20, 2025 at 3:05 PM Haruna Miwa <miwa(at)sraoss(dot)co(dot)jp> wrote:
> >
> > > Should we suggest "MERGE INTO" instead of just "MERGE",
> > > since INTO always follows MERGE?
> > >
> > > Also, how about adding "TABLE" and "WITH" to the suggestions,
> > > similar to the tab-completion for "COPY ("?
> > > SELECT statement can be specified in the PREPARE command,
> > > and it can start with SELECT, TABLE, or WITH [1].
> >
> > Agreed.
> > I have updated the patch.
>
> Thanks for the update!
>
> The patch looks good to me. I made one small adjustment: the updated line
> was a bit long, so I added a line break. I also revised the commit message.
>
> The updated patch is attached. I'll go ahead and commit it.

I've pushed the patch. Thanks!

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2025-11-23 14:39:31 Re: should we have a fast-path planning for OLTP starjoins?
Previous Message Greg Burd 2025-11-23 13:07:25 Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ​barriers