| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] doc: clarify AS requirement when VALUES used in a FROM clause |
| Date: | 2026-08-21 07:00:48 |
| Message-ID: | CAHGQGwFQbUtckXo9FoyDc4xj+SRZFNgyc7eCSbvDZTWVHnqsmg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 21, 2026 at 2:48 PM Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> True, but that omits the point the original documentation is making,
> i.e. that an
> AS clause should preferably specify names for all columns, so:
>
> Note that if <command>VALUES</command> is used in a
> <literal>FROM</literal> clause,
> it is not necessary to provide an <literal>AS</literal> clause, but
> it's good practice
> to do so and specify names for each column.
>
> I.e. don't do something like SELECT * FROM (values (1,2)) AS f(foo).
Thanks for updating the patch!
+ <command>VALUES</command> are
<literal>column1</literal>,<literal>column2</literal>,
A space should be added just after "<literal>column1</literal>,".
+ Note that if <command>VALUES</command> is used in a
<literal>FROM</literal> clause,
+ it is not necessary to provide an <literal>AS</literal> clause,
but it's good practice
+ to do so and specify names for each column. (The default column names for
Even when an alias is supplied, the AS keyword itself is optional, e.g.
FROM (VALUES (1, 2)) v(a, b). So I think it's better to avoid saying
"AS clause" here. Instead, how about using wording similar to queries.sgml,
as follows?
Note that if <command>VALUES</command> is used in a <literal>FROM</literal>
clause, a table alias is optional. Assigning alias names to the columns
of the <command>VALUES</command> list is optional, but is good practice.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Koshino Taiki | 2026-08-21 07:05:32 | doc: Reformat SELECT queries using GRAPH_TABLE |
| Previous Message | Bertrand Drouvot | 2026-08-21 06:55:19 | Re: Orphaned Files in PostgreSQL |