Re: [bug fix] pg_rewind creates corrupt WAL files, and the standby cannot catch up the primary

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_rewind creates corrupt WAL files, and the standby cannot catch up the primary
Date: 2018-03-27 19:45:49
Message-ID: CAHGQGwF+Fk0Oa-Qv37uT7YJMKGM1WLELvc4GN9Z4vHBvdZ=Prw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 11, 2018 at 11:04 PM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Mar 09, 2018 at 08:22:49AM +0000, Tsunakawa, Takayuki wrote:
>> Thanks for reviewing. All done.
>
> Thanks. Please be careful with the indentation of the patch. Attached
> is a slightly-updated version with a small modification in
> remove_target_file to make the code cleaner, a proposal of commit
> message and pgindent applied on the code. I am switching that as ready
> for committer.

The patch looks good to me! Barring objection, I will commit it
and back-patch to 9.5 where pg_rewind was added.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2018-03-27 20:21:09 Re: PATCH: Configurable file mode mask
Previous Message Fujii Masao 2018-03-27 19:13:25 Re: Using base backup exclusion filters to reduce data transferred with pg_rewind