Re: [bug fix] pg_rewind creates corrupt WAL files, and the standby cannot catch up the primary

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_rewind creates corrupt WAL files, and the standby cannot catch up the primary
Date: 2018-03-28 02:24:06
Message-ID: 20180328022406.GG1105@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 28, 2018 at 04:45:49AM +0900, Fujii Masao wrote:
> The patch looks good to me! Barring objection, I will commit it
> and back-patch to 9.5 where pg_rewind was added.

Thanks in advance! I just eyeballed the patch again and I don't see
issues with what's used here. The thing should apply smoothly back to
9.5, of course let me know if you need help or an extra pair of eyes.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-03-28 02:27:43 Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation()
Previous Message Craig Ringer 2018-03-28 02:23:46 PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS