| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Fabrizio Mello <fabrizio(at)planetscale(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix failing assert in deferred constraint trigger |
| Date: | 2026-09-11 08:47:22 |
| Message-ID: | CAHGQGwEyb5uYbgdYHfk_dJowZdZOXmxDVLEZm1yH=MMVLHT0OA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 11, 2026 at 11:33 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> V2 LGTM.
Thanks for the review!
> One nitpick is that, the fix covers both COMMIT and PREPARE TRANSACTION, but v2 only adds a regression test for the COMMIT case. Should we test both paths?
I think the COMMIT test is enough for this small assert-only fix.
But,iIf many others prefer explicit coverage for PREPARE TRANSACTION as well,
I'm fine with adding that test. It would probably require some additional test
logic to handle environments where max_prepared_transactions is disabled
(e.g., add "skip" like prepared_xacts.sql does).
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Grigorev Jurij | 2026-09-11 08:51:30 | [PATCH v1] Reject zero resource kinds in test_resowner_many() |
| Previous Message | Daniel Gustafsson | 2026-09-11 08:42:29 | Re: [DOC] pg_database_size/pg_tablespace_size error on a missing OID |