Re: Clear base backup progress reporting on error

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Clear base backup progress reporting on error
Date: 2026-06-26 10:46:45
Message-ID: CAHGQGwEw9SzBkRucqxpqL0UNcOeVefQbEAQyJrcfwn+72WWhWg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 26, 2026 at 5:59 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> This patch makes the following changes:

Thanks for the report and patch!

> I don’t think this is a serious bug, because with the usual pg_basebackup command path, the client normally disconnects after the error, so the stale progress entry is not observable. It is mainly visible when the same replication connection stays open after the failed BASE_BACKUP command. So I feel it might not be worth adding a TAP test.

+1

You may think this isn't worth backpatching to the stable branches
for the same reason?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vitaly Davydov 2026-06-26 10:59:04 Re: DDL deparse
Previous Message shveta malik 2026-06-26 10:30:32 Re: Proposal: Conflict log history table for Logical Replication