Re: Clear base backup progress reporting on error

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Clear base backup progress reporting on error
Date: 2026-06-26 11:08:17
Message-ID: 370AB27A-3905-455F-A3FB-7F24854D33AE@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jun 26, 2026, at 18:46, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Fri, Jun 26, 2026 at 5:59 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> This patch makes the following changes:
>
> Thanks for the report and patch!
>
>> I don’t think this is a serious bug, because with the usual pg_basebackup command path, the client normally disconnects after the error, so the stale progress entry is not observable. It is mainly visible when the same replication connection stays open after the failed BASE_BACKUP command. So I feel it might not be worth adding a TAP test.
>
> +1
>
> You may think this isn't worth backpatching to the stable branches
> for the same reason?
>

I personally don’t feel back-patch is needed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Henson Choi 2026-06-26 11:12:15 Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Previous Message Vitaly Davydov 2026-06-26 10:59:04 Re: DDL deparse