Re: Trivial fix for comment of function table_tuple_lock

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Trivial fix for comment of function table_tuple_lock
Date: 2025-09-22 04:42:03
Message-ID: CAHGQGwEkxYC_7A8RhWzAjiA2ApoGQ7MLoOALtkueChqc0=J=Sg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 11, 2025 at 2:40 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> Hi Hackers,
>
> Just fixed an one-word error in comment. Please take a look.

Thanks for the patch! LGTM.

It looks like this happened because heapam_tuple_lock() and heap_lock_tuple()
use the argument relation instead of rel, and the comments for
table_lock_tuple() were probably copied from heap_lock_tuple(),
leaving relation in place by mistake.

By the way, I noticed another typo in the comments for heap_lock_tuple():
the input parameter description for tid ("TID of tuple to lock")
should be removed,
since that function doesn’t take tid. How about fixing both issues in
the same patch,
since there’s no need to commit them separately?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2025-09-22 05:14:31 Re: Report bytes and transactions actually sent downtream
Previous Message Ashutosh Bapat 2025-09-22 03:40:29 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart