Re: Trivial fix for comment of function table_tuple_lock

Hi Fujii-san,

Thank you very much for taking care of this patch.

I just updated the patch, see attached v2. In v2, I removed "tid" from the
comment of heap_lock_tuple(), and I found a couple of more occurrences of
"relation"=>"rel" in tableam.h.

Best regards,
Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/

On Mon, Sep 22, 2025 at 12:42 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> On Thu, Sep 11, 2025 at 2:40 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >
> > Hi Hackers,
> >
> > Just fixed an one-word error in comment. Please take a look.
>
> Thanks for the patch! LGTM.
>
> It looks like this happened because heapam_tuple_lock() and
> heap_lock_tuple()
> use the argument relation instead of rel, and the comments for
> table_lock_tuple() were probably copied from heap_lock_tuple(),
> leaving relation in place by mistake.
>
> By the way, I noticed another typo in the comments for heap_lock_tuple():
> the input parameter description for tid ("TID of tuple to lock")
> should be removed,
> since that function doesn’t take tid. How about fixing both issues in
> the same patch,
> since there’s no need to commit them separately?
>
> Regards,
>
> --
> Fujii Masao
>