| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Subject: | Re: Reduce logging during prepared transaction recovery |
| Date: | 2026-10-19 03:25:30 |
| Message-ID: | CAHGQGwEikA=AJKf1dO3ufccoqr7W9FvvdZCHVzCQMXdetO_09A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 17, 2026 at 11:32 PM Pierre Forstmann
<pierre(dot)forstmann(at)gmail(dot)com> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested
>
> Hello,
>
> This patch looks good to me.
+1. I have one small suggestion, though.
The existing TAP test 009_twophase.pl already tests server startup with
prepared transactions. So, isn't it better to add the log checks there,
as in the attached patch?
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-v1-0002-Test-prepared-transaction-recovery-logging.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Zhijie Hou | 2026-10-19 02:52:26 | Re: Fix WITHOUT OVERLAPS multirange with location replication |