| From: | Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Subject: | Re: Reduce logging during prepared transaction recovery |
| Date: | 2026-10-17 14:31:59 |
| Message-ID: | 179224751940.1013883.3176071469864440170.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hello,
This patch looks good to me.
Before patching, I get after standby promotion:
2026-10-17 15:04:49.035 CEST [142400] LOG: recovering prepared transaction 37020 of epoch 0 from shared memory
2026-10-17 15:04:49.037 CEST [142400] LOG: recovering prepared transaction 37021 of epoch 0 from shared memory
2026-10-17 15:04:49.039 CEST [142400] LOG: recovering prepared transaction 37022 of epoch 0 from shared memory
2026-10-17 15:04:49.041 CEST [142400] LOG: recovering prepared transaction 37023 of epoch 0 from shared memory
2026-10-17 15:04:49.043 CEST [142400] LOG: recovering prepared transaction 37024 of epoch 0 from shared memory
2026-10-17 15:04:49.044 CEST [142400] LOG: recovering prepared transaction 37025 of epoch 0 from shared memory
2026-10-17 15:04:49.046 CEST [142400] LOG: recovering prepared transaction 37026 of epoch 0 from shared memory
2026-10-17 15:04:49.048 CEST [142400] LOG: recovering prepared transaction 37027 of epoch 0 from shared memory
2026-10-17 15:04:49.049 CEST [142400] LOG: recovering prepared transaction 37028 of epoch 0 from shared memory
2026-10-17 15:04:49.051 CEST [142400] LOG: recovering prepared transaction 37029 of epoch 0 from shared memory
2026-10-17 15:04:49.063 CEST [142398] LOG: checkpoint starting: force
2026-10-17 15:04:49.089 CEST [142398] LOG: 10 two-phase state files were written for long-running prepared transactions
2026-10-17 15:04:49.091 CEST [142394] LOG: database system is ready to accept connections
After patching I get after standby promotion:
2026-10-17 16:30:19.983 CEST [234528] LOG: recovered 10 prepared transactions
2026-10-17 16:30:19.993 CEST [234526] LOG: checkpoint starting: force
2026-10-17 16:30:20.019 CEST [234522] LOG: database system is ready to accept connections
2026-10-17 16:30:20.122 CEST [234526] LOG: 10 two-phase state files were written for long-running prepared transactions
I don't think there is need to test spec. compliance or to update the documentation.
Regards,
PF
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Osama Abdul Qader | 2026-10-17 14:34:03 | Re: [PATCH] Add immediate_global_insert_visibility GUC for immediate frozen inserts |
| Previous Message | Sehrope Sarkuni | 2026-10-17 14:22:27 | Re: Add Dockerfile for OSS Scanner |