| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log prefix missing for subscriber log messages received from publisher |
| Date: | 2025-07-22 05:29:51 |
| Message-ID: | CAHGQGwEhz+NGLsnB+qpc5gRdTA0Qw0Rzf-eUcNXibBU4Gp8bqA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 21, 2025 at 5:51 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Jul-21, Fujii Masao wrote:
>
> > Thanks for updating the patch! It looks good to me, except for one minor point:
> >
> > static inline PGresult *libpqsrv_get_result(PGconn *conn, uint32 wait_event_info);
> > +static inline void libpqsrv_notice_receiver(void *arg, const PGresult *res);
> >
> > This prototype is only needed if the function is used earlier in libpq-be-fe-helpers.h,
> > but that's not the case here, so I don't think it's necessary.
> >
> > Unless there are objections, I'll remove that prototype and commit the patch.
>
> LGTM.
I've pushed the patch. Thanks!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-07-22 05:36:37 | Re: IndexAmRoutine aminsertcleanup function can be NULL? |
| Previous Message | Fujii Masao | 2025-07-22 05:22:46 | pgsql: Log remote NOTICE, WARNING, and similar messages using ereport() |