| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log prefix missing for subscriber log messages received from publisher |
| Date: | 2025-07-21 08:51:14 |
| Message-ID: | 202507210851.cz7ct4ffpp76@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Jul-21, Fujii Masao wrote:
> Thanks for updating the patch! It looks good to me, except for one minor point:
>
> static inline PGresult *libpqsrv_get_result(PGconn *conn, uint32 wait_event_info);
> +static inline void libpqsrv_notice_receiver(void *arg, const PGresult *res);
>
> This prototype is only needed if the function is used earlier in libpq-be-fe-helpers.h,
> but that's not the case here, so I don't think it's necessary.
>
> Unless there are objections, I'll remove that prototype and commit the patch.
LGTM.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Debido a que la velocidad de la luz es mucho mayor que la del sonido,
algunas personas nos parecen brillantes un minuto antes
de escuchar las pelotudeces que dicen." (Roberto Fontanarrosa)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-07-21 08:52:53 | Re: Logical Replication of sequences |
| Previous Message | Aleksander Alekseev | 2025-07-21 08:48:27 | Re: Missing NULL check after calling ecpg_strdup |