Re: incorrect handling of the timeout in pg_receivexlog

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: incorrect handling of the timeout in pg_receivexlog
Date: 2012-06-06 18:10:18
Message-ID: CAHGQGwEbYM+9YPGq7ZwuEq8euRGubWs4WCujLsAWeUYkA4d_ng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 5, 2012 at 11:42 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Works for me. We still need a (reworked) patch, though, right? We just
> move where the move between seconds and milliseconds happens?

Attached is the updated version of the patch.

> I definitely don't think we need subsecond granularity in the user
> facing number. Even a second is pretty short.

Yep.

> (We do need to retain the ability to set it to 0 = off of course).

Yep, a value of zero disables the status updates, and the patch adds
that explanation into the document of pg_basebackup and pg_receivexlog.

Regards,

--
Fujii Masao

Attachment Content-Type Size
timeout_handling_v4.patch application/octet-stream 7.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-06-06 18:19:15 Re: "page is not marked all-visible" warning in regression tests
Previous Message Robert Haas 2012-06-06 17:55:02 Re: Ability to listen on two unix sockets