Re: incorrect handling of the timeout in pg_receivexlog

On Wed, Jun 6, 2012 at 8:10 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Jun 5, 2012 at 11:42 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Works for me. We still need a (reworked) patch, though, right? We just
>> move where the move between seconds and milliseconds happens?
>
> Attached is the updated version of the patch.

Thanks.

>> I definitely don't think we need subsecond granularity in the user
>> facing number. Even a second is pretty short.
>
> Yep.
>
>> (We do need to retain the ability to set it to 0 = off of course).
>
> Yep, a value of zero disables the status updates, and the patch adds
> that explanation into the document of pg_basebackup and pg_receivexlog.

Applied, with some small modifications. For example, you don't need a
frontend-specific copy of #define's that are in the backend, since
those don't require linking to the backend, just the #include.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/