| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Robert Treat <rob(at)xzilla(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOC: fixes multiple errors in alter table doc |
| Date: | 2026-03-06 06:40:30 |
| Message-ID: | CAHGQGwEQZp3TotP9Aga0tpGj5fcAKSwH8uwHkR2Cc=BM8Q9VMg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 5, 2026 at 2:06 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > -- alter noexisting table
> > ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 ADD COLUMN c4 integer;
> > +ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 ADD c5 integer;
> > <snip>
> > ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 DROP COLUMN IF EXISTS no_column;
> > +ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 DROP IF EXISTS no_column;
> >
> > Regarding 0002 patch, could you explain the reason for adding these
> > two additional tests? I was just curious why because other four tests that
> > the patch adds seem sufficient.
>
> They are combinations of “IF [NOT] EXISTS” and omitting “COLUMN", I added them just for better coverage.
Which table-level or column-level "IF [NOT] EXISTS" are you referring to?
If you mean the combination of column-level "IF [NOT] EXISTS" with
"COLUMN" omitted, then the first test above should be "ALTER FOREIGN TABLE
IF EXISTS doesnt_exist_ft1 ADD IF NOT EXISTS c5 integer"?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-03-06 06:44:20 | Re: Add Option To Check All Addresses For Matching target_session_attr |
| Previous Message | Tatsuo Ishii | 2026-03-06 06:38:37 | Re: Row pattern recognition |