Re: DOC: fixes multiple errors in alter table doc

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Treat <rob(at)xzilla(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DOC: fixes multiple errors in alter table doc
Date: 2026-03-05 05:05:27
Message-ID: 02535813-A4C9-4A57-838A-3FB97A6EA89A@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mar 5, 2026, at 12:42, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Tue, Mar 3, 2026 at 5:05 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> PFA v5:
>>
>> * In 0002, renamed c12 to c11 in the ALTER FOREIGN TABLE tests.
>> * In 0002, added one more test case: ALTER FOREIGN TABLE ft1 DROP IF EXISTS no_column;
>
> Thanks for updating the patches!
>
> I've committed the 0001 patch and backpatched it to all supported versions.
>
>
> -- alter noexisting table
> ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 ADD COLUMN c4 integer;
> +ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 ADD c5 integer;
> <snip>
> ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 DROP COLUMN IF EXISTS no_column;
> +ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 DROP IF EXISTS no_column;
>
> Regarding 0002 patch, could you explain the reason for adding these
> two additional tests? I was just curious why because other four tests that
> the patch adds seem sufficient.

They are combinations of “IF [NOT] EXISTS” and omitting “COLUMN", I added them just for better coverage.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2026-03-05 05:20:49 Re: Row pattern recognition
Previous Message ls7777 2026-03-05 05:04:05 Patch for migration of the pg_commit_ts directory