| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "Masashi Kamura (Fujitsu)" <kamura(dot)masashi(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, lakshmi <lakshmigcdac(at)gmail(dot)com> |
| Subject: | Re: ECPG: inconsistent behavior with the document in “GET/SET DESCRIPTOR.” |
| Date: | 2026-05-29 03:11:38 |
| Message-ID: | CAHGQGwE9C_X4=bWFyLA_UGuajOMJufxxut-WSTXuUtr33xkswA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 27, 2026 at 11:39 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Hi hackers,
>
> Overall: The author found the case pre-compilation could succeed but the actual
> compilation would fail, with SET/GET DESCRIPTOR. This patch tries to detect the
> pre-compilation phase and raise a failure.
The patch looks good to me.
Barring any objections, I'm thinking to commit it.
> Based on the SQL standard/other
> DBMSs/history, it's not meaningful to allow the statement.
> This does not contain tests because we cannot compile such a test program in the
> first place.
I'm not sure this case warrants regression tests, but if we need them,
the attached patch adds them.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-regression-tests-to-verify-that-duplicate-COU.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-05-29 03:17:13 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Zhijie Hou (Fujitsu) | 2026-05-29 02:59:54 | RE: Bound memory usage during manual slot sync retries |