| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Fujii Masao' <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | "Masashi Kamura (Fujitsu)" <kamura(dot)masashi(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, lakshmi <lakshmigcdac(at)gmail(dot)com> |
| Subject: | RE: ECPG: inconsistent behavior with the document in “GET/SET DESCRIPTOR.” |
| Date: | 2026-05-29 03:44:22 |
| Message-ID: | OS9PR01MB12149385413D75455B020E259F5162@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Fujii-san,
> > Overall: The author found the case pre-compilation could succeed but the actual
> > compilation would fail, with SET/GET DESCRIPTOR. This patch tries to detect
> the
> > pre-compilation phase and raise a failure.
>
> The patch looks good to me.
> Barring any objections, I'm thinking to commit it.
Thanks!
>
> > Based on the SQL standard/other
> > DBMSs/history, it's not meaningful to allow the statement.
> > This does not contain tests because we cannot compile such a test program in
> the
> > first place.
>
> I'm not sure this case warrants regression tests, but if we need them,
> the attached patch adds them.
Oh, I didn't recognized that we had TAP tests to detect error/warnings by the pre compiler.
I do not have strong opinions for it.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-05-29 04:17:17 | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |
| Previous Message | Chao Li | 2026-05-29 03:38:40 | Re: Fix race during concurrent logical decoding activation |