RE: Bound memory usage during manual slot sync retries

On Friday, May 29, 2026 10:31 AM Xuneng Zhou <xunengzhou(at)gmail(dot)com> wrote:
>
> On Fri, May 29, 2026 at 12:43 AM Khoa Nguyen <kdnguyen9(dot)oss(at)gmail(dot)com>
> wrote:
> >
> > I also reviewed the script and it is well done. The script setup and
> > capture data points showing memory leak within the session over time.
> > The patch looks fine though I think that oldctx should be captured
> > once outside the retry loop since the current logic is more about
> > parent and child memory context rather than previous and current
> > context. Nevertheless, the current code works as well.
>
> Thanks for your review and verification. I agree with your suggestion
> that capturing the outer memory context once outside the retry loop
> looks cleaner and reflect the lifetime model better. I am also
> wondering whether renaming the oldctx to outerctx could express the
> parent/child relationship more clearly. That said, I am ok with the
> status quo, if Amit thinks no further modification is needed.

I am personally -1 on this change. The patch makes the logic somewhat harder for
me to follow and understand. IIUC, the patch assumes that all code executed
after creating sync_retry_ctx should fall under the 'outerctx'. This assumption
seems fragile as it could easily be broken if someone creates another temp
context and places the entire loop logic inside that context.

Best Regards,
Hou zj