Re: ALTER SUBSCRIPTION ..SET PUBLICATION <no name> refresh is not throwing error.

From: Euler Taveira <euler(at)timbira(dot)com(dot)br>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER SUBSCRIPTION ..SET PUBLICATION <no name> refresh is not throwing error.
Date: 2017-05-27 02:00:46
Message-ID: CAHE3wgignJiJ8OU4iuUSE2n3YrjB=r-_g7h5DxwjstKnY9jnFw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2017-05-26 21:29 GMT-03:00 Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>:

>
> Actually another possibility would be to remove the REFRESH keyword
> completely and just have [ WITH (...) ] and have the refresh option
> there, ie simplified version of what you have suggested (without the
> ugliness of specifying refresh twice to disable).

It will cause confusion. It seems that WITH sets ALTER SUBSCRIPTION
properties. Indeed, they are REFRESH properties. I think we shouldn't
exclude REFRESH keyword. Syntax leaves no doubt that WITH are REFRESH
properties.

--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
<http://www.timbira.com.br>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2017-05-27 02:43:05 Re: logical replication - still unstable after all these months
Previous Message Euler Taveira 2017-05-27 01:46:12 Re: pg_dump ignoring information_schema tables which used in Create Publication.