Re: BUG #19367: typos in backend/utils/adt/timestamp.c

From: Rahila Syed <rahilasyed90(at)gmail(dot)com>
To: fadeymail(at)rambler(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19367: typos in backend/utils/adt/timestamp.c
Date: 2025-12-29 10:25:50
Message-ID: CAH2L28tGUhoH21j_+RP9X0g=s=G0NmuMYxOKZKSspamvEe3i-Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi,

There are typos in return type of these functions:
> 1) timestamptz_pl_interval_at_zone(PG_FUNCTION_ARGS)
> NOW: PG_RETURN_TIMESTAMP(timestamptz_pl_interval_internal(timestamp,
> span, attimezone));
> SHOULD:
> PG_RETURN_TIMESTAMPTZ(timestamptz_pl_interval_internal(timestamp, span,
> attimezone));
> 2) Datum timestamptz_mi_interval_at_zone(PG_FUNCTION_ARGS)
> NOW: PG_RETURN_TIMESTAMP(timestamptz_mi_interval_internal(timestamp,
> span, attimezone));
> SHOULD:
> PG_RETURN_TIMESTAMPTZ(timestamptz_mi_interval_internal(timestamp, span,
> attimezone));
>
>
You’re right — these are just typos, and they don’t affect correctness
since both
ultimately call Int64GetDatum().
Still, +1 for fixing them for clarity.

Thank you,
Rahila Syed

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Japin Li 2025-12-29 10:35:29 Re: BUG #19367: typos in backend/utils/adt/timestamp.c
Previous Message PG Bug reporting form 2025-12-29 09:13:39 BUG #19367: typos in backend/utils/adt/timestamp.c