| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] A design for amcheck heapam verification |
| Date: | 2017-11-29 05:48:10 |
| Message-ID: | CAH2-WznnGke6iFfY=CkYVMNsCPeNxcJR0jzqGM4FQQzknujuDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 28, 2017 at 9:38 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> My apologies for slacking here. I would still welcome some regression
> tests to stress the bloom API you are proposing! For now I am moving
> this patch to next CF.
I still don't think that regression tests as such make sense. However,
it seems like it might be a good idea to add a test harness for the
Bloom filter code. I actually wrote code like this for myself during
development, that could be cleaned up. The hardness can live in
source/src/test/modules/test_bloom_filter. We already do this for the
red-black tree library code, for example, and it seems like good
practice.
Would that address your concern? There would be an SQL interface, but
it would be trivial.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-11-29 05:48:54 | Re: [HACKERS] Function to move the position of a replication slot |
| Previous Message | Michael Paquier | 2017-11-29 05:46:33 | Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs |