| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] A design for amcheck heapam verification |
| Date: | 2017-11-29 05:50:41 |
| Message-ID: | CAB7nPqSBZJofXvhq1MsxZpmip2Z4qupsLr=HyDSup44XrN-3RQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 29, 2017 at 2:48 PM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> I still don't think that regression tests as such make sense. However,
> it seems like it might be a good idea to add a test harness for the
> Bloom filter code. I actually wrote code like this for myself during
> development, that could be cleaned up. The hardness can live in
> source/src/test/modules/test_bloom_filter. We already do this for the
> red-black tree library code, for example, and it seems like good
> practice.
>
> Would that address your concern? There would be an SQL interface, but
> it would be trivial.
That's exactly what I think you should do, and mentioned so upthread.
A SQL interface can also show a good example of how developers can use
this API.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-11-29 05:54:39 | Re: [HACKERS] A design for amcheck heapam verification |
| Previous Message | Michael Paquier | 2017-11-29 05:48:54 | Re: [HACKERS] Function to move the position of a replication slot |