| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Ewan Young <kdbase(dot)hack(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Hash index AM fake LSN oversight |
| Date: | 2026-07-16 22:11:18 |
| Message-ID: | CAH2-WznfA==hUFdN8YEYkhFiTL0X_roQ1MDeCiRygfqZLNDw+A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 15, 2026 at 2:47 AM Ewan Young <kdbase(dot)hack(at)gmail(dot)com> wrote:
> Confirmed -- log_split_page() is the only data-page site e5836f7b left
> without a fake-LSN branch (the _hash_init meta/bitmap paths set the LSN
> under WAL only, but those aren't read concurrently, so that's expected).
> The fix is correct.
Pushed. Thanks for the review!
> One optional cosmetic point: the other fake-LSN sites, including the two
> functions e5836f7b just reworked in this file, hoist recptr out of the
> if and call PageSetLSN once afterwards, rather than once per branch.
I agree that it works slightly better that way; that's what I did in
the committed version.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2026-07-16 22:19:33 | Re: ci: namespace ccache by PostgreSQL major version |
| Previous Message | Michael Paquier | 2026-07-16 22:00:10 | Re: WAL compression setting after PostgreSQL LZ4 default change |