Re: [HACKERS] Replication to Postgres 10 on Windows is broken

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Augustine, Jobin" <jobin(dot)augustine(at)openscg(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Replication to Postgres 10 on Windows is broken
Date: 2017-08-13 20:35:53
Message-ID: CAH2-WznYD-V4OepVGVoEmc9bYVp49JP5eFG65n81sTA_kXouLg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Sun, Aug 13, 2017 at 12:57 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> FWIW, I'm personally quite demotivated by this style of handling
> issues. You're essentially saying that any code change, even if it just
> increases exposure of a preexisting bug, needs to be handled by the
> committer of the exposing change. And even if that bug is on a platform
> the committer doesn't have. And all that despite the issue getting
> attention.

I don't think you can generalize from what Noah said like that,
because it's always a matter of degree (the degree to which the
preexisting bug was a problem). Abbreviated keys for collated text
were disabled, though not due to bug in strxfrm(). Technically, it was
due to a bug in strcoll(), which glibc always had. strxfrm() therefore
only failed to be bug compatible with glibc's strcoll(). Does that
mean that we were wrong to disable the use of strxfrm() for
abbreviated keys?

I think that it's useful for these things to be handled in an
adversarial manner, in the same way that litigation is adversarial in
a common law court. I doubt that Noah actually set out to demoralize
anyone. He is just doing the job he was assigned.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2017-08-13 20:47:28 Re: [HACKERS] Replication to Postgres 10 on Windows is broken
Previous Message Andres Freund 2017-08-13 20:04:38 Re: [HACKERS] Replication to Postgres 10 on Windows is broken

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-08-13 20:47:28 Re: [HACKERS] Replication to Postgres 10 on Windows is broken
Previous Message Andres Freund 2017-08-13 20:04:38 Re: [HACKERS] Replication to Postgres 10 on Windows is broken