Re: [HACKERS] Replication to Postgres 10 on Windows is broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: "Augustine, Jobin" <jobin(dot)augustine(at)openscg(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Replication to Postgres 10 on Windows is broken
Date: 2017-08-13 20:47:28
Message-ID: 21794.1502657248@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-08-11 18:11:03 +0530, Augustine, Jobin wrote:
>> Appears that patch is not helping.

> That's too bad. Any chance you could install
> https://docs.microsoft.com/en-us/sysinternals/downloads/procmon and
> activate monitoring just for that phase? I think it can export to a text
> file...

It strikes me that maybe the misuse of io_flag could be contributing
to this: if the walreceiver process's latch were set, we'd end up calling
PQconnectPoll before the socket had necessarily come ready, which would
produce the described symptom. That's grasping at straws admittedly,
because I'm not sure why the walreceiver process's latch would be set
at this point; but it seems like we ought to test a version of the patch
that we believe correct before deciding that we still have a problem.

To move things along, here's a corrected patch --- Jobin, please test.

regards, tom lane

Attachment Content-Type Size
add-connected-event-2.patch text/x-diff 6.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2017-08-13 20:55:33 Re: [BUGS] Replication to Postgres 10 on Windows is broken
Previous Message Peter Geoghegan 2017-08-13 20:35:53 Re: [HACKERS] Replication to Postgres 10 on Windows is broken

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Tiikkaja 2017-08-13 20:48:56 Re: Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING
Previous Message Peter Geoghegan 2017-08-13 20:35:53 Re: [HACKERS] Replication to Postgres 10 on Windows is broken