| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: IndexTupleDSize macro seems redundant |
| Date: | 2017-11-30 21:50:37 |
| Message-ID: | CAH2-WzmUqqeBLu0VMUijnXK4LnGQjBKKX5d2zaHzXQRdmf+Grg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 30, 2017 at 1:48 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> One difference between those two macros is that IndexTupleSize
> forcibly casts the argument to IndexTuple, which means that you don't
> get any type-checking when you use that one. I suggest that in
> addition to removing IndexTupleDSize as proposed, we also remove that
> cast. It seems that the only place which relies on that cast
> currently is btree_xlog_split.
>
> Therefore I propose the attached patch instead.
+1 to both points. I specifically recall being annoyed by both issues,
more than once.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergei Kornilov | 2017-11-30 22:05:52 | Re: using index or check in ALTER TABLE SET NOT NULL |
| Previous Message | Robert Haas | 2017-11-30 21:48:23 | Re: IndexTupleDSize macro seems redundant |