Re: pgsql: Make heap TID a tiebreaker nbtree index column.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.
Date: 2019-03-21 22:34:22
Message-ID: CAH2-WzmMakut=D8=TnmzhGtB+ELbb6k84LYNW28C8MZ2D-ZoJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Mar 20, 2019 at 8:17 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Actually, I'm not sure why it would be fine to revert 7d3bf73ac now.
> > Might the problem actually be the order in which OIDs are originally
> > assigned, or something like that?
>
> No, because then things would have been unstable before, no?

Perhaps. The cost of being wrong here is trivial anyway. I have
reverted 7d3bf73ac based on the assumption that it's now unnecessary.

> I actually think that we should remove most or all of the
> cascade-drop-hiding hacks that are in the regression tests now,
> not only that one. They should not be necessary any more, and
> they might be hiding things we need to know about, now or in
> the future. But I haven't got round to it.

Seems like a useful goal.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-03-22 03:26:12 Re: pgsql: Add pg_partition_root to display top-most parent of a partition
Previous Message Peter Geoghegan 2019-03-21 22:33:50 pgsql: Revert "Suppress DETAIL output from a foreign_data test."