Re: pgsql: Make heap TID a tiebreaker nbtree index column.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.
Date: 2019-03-22 16:32:57
Message-ID: 5446.1553272377@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> On Wed, Mar 20, 2019 at 8:17 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Actually, I'm not sure why it would be fine to revert 7d3bf73ac now.
>>> Might the problem actually be the order in which OIDs are originally
>>> assigned, or something like that?

>> No, because then things would have been unstable before, no?

> Perhaps. The cost of being wrong here is trivial anyway. I have
> reverted 7d3bf73ac based on the assumption that it's now unnecessary.

Apparently, that case is indeed unstable, cf

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fulmar&dt=2019-03-22%2016%3A15%3A14

I picked up on that because I've also seen it happen on my own
devel machine today, but just once --- I then tried to reproduce it,
but couldn't in several dozen tries.

I'm fairly baffled as to why the output order would be unstable
given the sort, and even more as to why the instability didn't
emerge before. Any thoughts?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-03-22 17:13:03 Re: pgsql: Make heap TID a tiebreaker nbtree index column.
Previous Message Heikki Linnakangas 2019-03-22 16:02:04 pgsql: Fix yet more portability bugs in integerset and its tests.