| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Btree BackwardScan race condition on Standby during VACUUM |
| Date: | 2020-03-17 19:37:57 |
| Message-ID: | CAH2-Wzm7T_O+VUeo7=_NGPncs08z3JEybEwVLZGaASnbfg5vDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 16, 2020 at 10:20 PM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> It seems to me that it's exactly the same check that I was trying to verify in amcheck patch [0].
> But there it was verified inside amcheck, but here it is verified by index scan.
Maybe we can accept your patch after fixing this bug. My objection to
the patch was that it couples locks in a way that's not compatible
with btree_xlog_unlink_page(). But the problem now seems to have been
btree_xlog_unlink_page() itself. It's possible that there are problems
elsewhere, but my recollection is that btree_xlog_unlink_page() was
the problem.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2020-03-17 19:39:35 | Re: Adding missing object access hook invocations |
| Previous Message | Peter Geoghegan | 2020-03-17 19:30:14 | Re: [PATCH] Btree BackwardScan race condition on Standby during VACUUM |