| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Guofenglinux <guofenglinux(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: [PG19] eager aggregation gives wrong results because of bpchar_ops |
| Date: | 2026-10-06 18:43:47 |
| Message-ID: | CAH2-Wzm4kGV4uMJv-U65PJiDzNcCZWLpumgVHmAg6fgKYQVgCw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 6, 2026 at 1:05 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> Thanks for going to the trouble. I'll prepare a fix for these issues.
Attached are lightly edited versions of Shihao Zhong's bug fix
patches, incorporating the revisions I agreed to earlier today.
Note again that the patch that's intended for the released back
branches deliberately ignores the oidvector issue. Also, there are no
changes to system catalog contents on released branches (just 19 and
master), which isn't how Noah's similar 2023 interval_ops commit did
things. Shihao followed that precedent, but I don't think it's
appropriate to change the contents of the catalogs that initdb
creates, unless it's truly unavoidable.
If there are no objections, I'll commit these in the next couple of days.
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v2_REL_18_STABLE-0001-Rescind-unsafe-deduplication-suppor.patch | application/octet-stream | 6.4 KB |
| v2_master-0001-Rescind-unsafe-deduplication-support.patch | application/octet-stream | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sehrope Sarkuni | 2026-10-06 18:44:00 | Bug: ATTACH PARTITION can leave rows violating default partition constraint |
| Previous Message | Khoa Nguyen | 2026-10-06 18:41:31 | Re: [PATCH] vacuumdb: Add --exclude-database option |