| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Guofenglinux <guofenglinux(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: [PG19] eager aggregation gives wrong results because of bpchar_ops |
| Date: | 2026-10-06 19:15:50 |
| Message-ID: | 1437400.1791314150@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> Attached are lightly edited versions of Shihao Zhong's bug fix
> patches, incorporating the revisions I agreed to earlier today.
> Note again that the patch that's intended for the released back
> branches deliberately ignores the oidvector issue. Also, there are no
> changes to system catalog contents on released branches (just 19 and
> master), which isn't how Noah's similar 2023 interval_ops commit did
> things. Shihao followed that precedent, but I don't think it's
> appropriate to change the contents of the catalogs that initdb
> creates, unless it's truly unavoidable.
Patches LGTM. I could go along with removing those entries from the
.dat files in the older branches, but not doing so is fine too.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-10-06 19:29:18 | Re: REPACK (CONCURRENTLY) can't complete after ~105M concurrent updates/deletes |
| Previous Message | Manu | 2026-10-06 19:00:29 | Re: Proposal: "query_work_mem" GUC, to distribute working memory to the query's individual operators |