| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, scott(at)scottray(dot)io |
| Subject: | Re: Snapshot export on a standby corrupts hint bits on subxact overflow |
| Date: | 2026-08-26 20:50:37 |
| Message-ID: | CAH2-Wzksf0QMwFV_JVgpG79CqCM7x_4071-o6Sx5PbjVd=1KbQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pushed.
On Tue, Aug 25, 2026 at 5:32 AM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> On Mon, Aug 24, 2026 at 07:07:07PM -0400, Peter Geoghegan wrote:
> > On Wed, Jul 29, 2026 at 5:36 AM Bertrand Drouvot
> > <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> > > > 1/ In ExportSnapshot(), do not include recovery subxip entries and committed
> > > > child XIDs at or above xmax when counting and serializing them, so unnecessary
> > > > entries do not consume the limited recovery subxip capacity.
> >
> > That is a valid issue, but I wonder if it's worth including in a
> > back-patchable fix. Is the special case worth the added risk?
>
> Yeah, probably not. What about adding an XXX here:
In the committed version, we raise a specific ERROR when this happens.
I think it's unlikely that any user will ever see this ERROR, but it's
better to have it and not need it.
Thanks
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mihail Nikalayeu | 2026-08-26 21:06:00 | Re: Apply worker can pick an invalid index for REPLICA IDENTITY FULL lookups |
| Previous Message | Daniel Gustafsson | 2026-08-26 20:37:09 | Re: Offline data checksum changes can cause incorrect checksum state on standbys |