| From: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, onderkalaci(at)gmail(dot)com |
| Subject: | Re: Apply worker can pick an invalid index for REPLICA IDENTITY FULL lookups |
| Date: | 2026-08-26 21:06:00 |
| Message-ID: | CADzfLwV+bpRVDHH4DkhwPq36KOjYO08EQr+G+ggwWY2jHPiFwA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello!
> The patch looks good, just a small suggestion that the function header
> of IsIndexUsableForReplicaIdentityFull() probably could do with a
> comment so that future callers are aware of this potential shortfall.
Done.
> Thanks for the patch, the patch does not apply on PG17 version, you
> might have to provide a separate patch for PG17 & below version:
Done.
> I think it is better to add some comments in the code as well. See
> attached. I have added # in the test comments to make it similar to
> the previous test. Otherwise, the patch LGTM.
Applied, thanks.
Regards,
Mikhail.
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-v1-REL_16-0001-Don-t-choose-an-invalid-index-for-REPLICA-IDENTITY-FULL.patch | application/octet-stream | 6.4 KB |
| v1-0001-Don-t-choose-an-invalid-index-for-REPLICA-IDENTITY-FULL.patch | application/octet-stream | 6.5 KB |
| nocfbot-v1-REL_17-0001-Don-t-choose-an-invalid-index-for-REPLICA-IDENTITY-FULL.patch | application/octet-stream | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Taha Naveed | 2026-08-26 21:12:51 | [PATCH] SQL/PGQ: Fix inferred property graph keys with INCLUDE columns |
| Previous Message | Peter Geoghegan | 2026-08-26 20:50:37 | Re: Snapshot export on a standby corrupts hint bits on subxact overflow |