| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: strange perf regression with data checksums |
| Date: | 2025-06-04 17:39:40 |
| Message-ID: | CAH2-Wzkfc70F0_2DxiepMUNLEDnnw-+-hYUVmpzGyJ6w+JnwxA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 4, 2025 at 10:21 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Wed, Jun 4, 2025 at 7:33 AM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> > So better to get this in now, otherwise we may have to wait until PG19,
> > because of ABI (the patch adds a field into BTScanPosData, but maybe
> > it'd be possible to add it into padding, not sure).
>
> I agree. I can get this into shape for commit today.
Attached is v3, which is functionally the same as v2. It has improved
comments, and a couple of extra assertions. Plus there's a real commit
message now.
I also relocated the code that sets so.drop_pin from
_bt_preprocess_keys to btrescan. That seems like the more logical
place for it.
My current plan is to commit this in the next couple of days.
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Avoid-BufferGetLSNAtomic-calls-during-nbtree-scan.patch | application/octet-stream | 11.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-06-04 17:46:02 | Re: Fix slot synchronization with two_phase decoding enabled |
| Previous Message | Sami Imseih | 2025-06-04 16:51:56 | Re: Improve explicit cursor handling in pg_stat_statements |