Re: [HACKERS] Small improvement to compactify_tuples

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Юрий Соколов <funny(dot)falcon(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Claudio Freire <klaussfreire(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Sokolov Yura <funny(dot)falcon(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Small improvement to compactify_tuples
Date: 2017-11-28 23:00:04
Message-ID: CAH2-Wzk19G5=RxQpgfUirRvihjrMvZSMSi=u53TbMbvLj1+5vA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 28, 2017 at 2:41 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Maybe it's a stupid question. But would we still want to have this after
> the change? These should be just specializations of the template version
> imo.

I also wonder why regression test output has changed. Wasn't this
supposed to be a mechanical change in how the templating is
implemented? Why would the behavior of the algorithm change, even if
the change is only a change in the output order among equal elements?

Also, is that one last raw CHECK_FOR_INTERRUPTS() in the template
definition supposed to be there?

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-11-28 23:12:11 Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause
Previous Message Tom Lane 2017-11-28 22:57:48 Re: pgindent run?