Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()
Date: 2021-02-14 22:33:07
Message-ID: CAH2-Wz=VkCRNUVFWK=3XfGLMW2_jxnBwF-JBUAQfstzaEehkKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 14, 2021 at 2:08 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> I prefer "next", because that's in the name of the variable it reads,
> and the variable name seemed to me to have a more obvious meaning.
> That's why I went for that name in commit 2fc7af5e966. I do agree
> that it's slightly strange that the 32 and 64 bit versions differ
> here. I'd vote for renaming the 32 bit version to match...

I was just going to say the same thing myself.

Please do the honors if you have time...

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2021-02-14 22:38:01 Re: WIP: WAL prefetch (another approach)
Previous Message Thomas Munro 2021-02-14 22:07:37 Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()