Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()
Date: 2021-02-15 00:20:29
Message-ID: CA+hUKGKsO5EPB9OVk6OKAEtjXNCaOPVwSOVPH6BOE0zONMp08Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 15, 2021 at 11:33 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Sun, Feb 14, 2021 at 2:08 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > I prefer "next", because that's in the name of the variable it reads,
> > and the variable name seemed to me to have a more obvious meaning.
> > That's why I went for that name in commit 2fc7af5e966. I do agree
> > that it's slightly strange that the 32 and 64 bit versions differ
> > here. I'd vote for renaming the 32 bit version to match...
>
> I was just going to say the same thing myself.
>
> Please do the honors if you have time...

Done.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Bergbauer 2021-02-15 00:42:19 Re: Preventing free space from being reused
Previous Message Stephen Frost 2021-02-14 23:18:15 Re: WIP: WAL prefetch (another approach)