| From: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unordered wait event ClogGroupUpdate |
| Date: | 2018-10-24 04:55:37 |
| Message-ID: | CAGz5QCKUuwu_qeVVnXTOMztKC0_BkKwijp-ONkBVTPjNU3BgAw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 24, 2018 at 5:56 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> baaf272 has added support for group updates in clog, however it has
> added the wait event WAIT_EVENT_CLOG_GROUP_UPDATE in a non-alphabetical
> order. There are many events, so keeping things in order helps users in
> finding them.
That's a valid argument. Additionally, I've found
WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING and
WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING are added in a
non-alphabetical order in WaitEventIPC enum.
> Are there any objections to the attached, which reorders things
> properly? This is a patch for HEAD, for v11 I propose to only fix the
> documentation side of things to avoid an ABI breakage.
+1
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-24 05:12:51 | Re: Restore CurrentUserId only if 'prevUser' is valid when abort transaction |
| Previous Message | David Fetter | 2018-10-24 03:26:23 | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER |