| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] pg_surgery: check the page header and line pointers |
| Date: | 2026-09-05 12:48:58 |
| Message-ID: | CAGRkXqT_V5wxz2L_MFp1QYSsEQpQsrSUDxFu55VCgBzH9=Yv2g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Andrey,
Thanks for reviewing!
> I think heap_force_freeze() needs one more check.
I agree with you, check added
> See amcheck tests fro details, but I'm not sure it actually
> worth the trouble here.
In my opinion, every change we made should have some
kind of regression tests. I understand there are resource
limit for machines but I believe engineering wise this is the
right way to do.
I added a TAP test to simulate a corrupt page.
Thanks
Shihao
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_surgery-bound-the-page-s-max-offset-by-MaxHeap.patch | application/octet-stream | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-09-05 13:11:37 | [DOC] pg_database_size/pg_tablespace_size error on a missing OID |
| Previous Message | Hannu Krosing | 2026-09-05 12:24:50 | Direct TOAST v2, faster, smaller and no migration needed |