Re: [PATCH] pg_surgery: check the page header and line pointers

Thanks, v2 addresses both points. The code changes look good to me.

The TAP test still has one small portability issue: it hardcodes 8192.
It does not need to support every BLCKSZ, but it could read SHOW
block_size and skip unless it is 8192. Otherwise a 4 kB build rejects
the header in PageIsVerified() before reaching the new check.

+# t_lp: leave the header alone, but point the first line pointer past the
+# end of the page. Item is (lp_off = 32767, lp_flags = LP_NORMAL,
+# lp_len = 100) packed into the 32-bit ItemIdData word.

The exact lp_off and lp_len values produced by the packed ItemIdData
word depend on the platform's bit-field ordering. The word is invalid
with either ordering, so the test is fine, but the comment can avoid
claiming those exact values.

With those minor test adjustments, this looks ready for committer to me.

Best regards, Andrey Borodin.