Re: BUG #19817: CREATE UNIQUE INDEX on a partitioned table can silently attach an invalid, not-ready child index, le

Hi Dilip,

Thanks for working on this! v2 looks great!

I have one concern here:

This patch skips partitioned indexes made with ON ONLY, which are invalid
until their partitions are attached. This breaks a case that works on
master:

create table r (a int not null) partition by range (a);
create table s partition of r for values from (0) to (100)
partition by range (a);
create table s1 partition of s for values from (0) to (100);
alter table only s add primary key (a);
alter table r add primary key (a);

With v2 the last command fails:

ERROR: multiple primary keys for table "s" are not allowed

Maybe skip only invalid indexes that are not partitioned?

Thanks,
Shihao