Re: BUG #19827: postgres_fdw: Assert in add_foreign_ordered_paths() with redundant ORDER BY in set-op input

On Wed, 4 Nov 2026 at 00:23, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
> On Tue, 3 Nov 2026 at 11:44, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > I think we should fix this in the backbranches by modifying the Assert
> > to allow sort_pathkeys to be NIL.
>
> > Fixing it this way won't result in any plan changes for existing
> > queries, which is imporant for backpatching.
>
> +1. Agree with the need to ensure back branches' plans don't change here.
> On a quick check, both v2 patches tested fine for me:
>
> - v2-0001 was tested on REL_17_STABLE .. REL_19_STABLE. It applies,
> compiles with no warnings, and make check / postgres_fdw's
> tests pass.
> - Similarly v2-0001 + v2-0002 on master passes both tests too.

Thanks for having a look. I've now backpatched 0001 and applied 0002 to master.

David