| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: REPACK (CONCURRENTLY) decoding worker is canceled by lock_timeout |
| Date: | 2026-11-12 04:40:05 |
| Message-ID: | CAGRkXqT9ScmpsQYzEo2C+PGS2_4Lxa2Tn_7zvm=pbOvGi1+AUg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alvaro,
> I have pushed this, thanks.
Thanks for pushing that.
> I am concerned about the GUC variables changing type and the repack code
> not noticing....
I think we can just use type of + StaticAssertVariableIsOfType here, a new
patch
is attached about that.
> I don't understand why you were adding #include "fd.h" to repack.c.
ehh, that is auto imported by ide, my mistake. Will recheck all the
#include for
future patches.
Thanks,
Shihao
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Check-the-types-of-the-settings-passed-to-the-REP.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-11-12 04:44:39 | Re: Crashes on a partition whose concurrent detach never finished |
| Previous Message | shihao zhong | 2026-11-12 04:36:50 | Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned |