Re: REPACK (CONCURRENTLY) decoding worker is canceled by lock_timeout

Hi,

On 2026-Sep-17, shihao zhong wrote:

> Hi Alvaro,
>
> I looked at the other settings to see if any of them has the same
> problem. I found temp_file_limit, the worker uses it for its decoding
> files. 003 fixes it the same way as the timeouts.

I have pushed this, thanks.

I am concerned about the GUC variables changing type and the repack code
not noticing. Suppose temp_files_limit were changed to be int64; we
don't receive a compiler warning for the mismatching type in
repack_internal.h. I thought about adding a
StaticAssertVariableIsOfType, but I have no idea how to make it compare
not to a type, but to the type of some other variable. These _Generic()
things are unknown to me.

I don't understand why you were adding #include "fd.h" to repack.c.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Finally, the phrase, 'No one was ever fired for buying an IBM' I don't believe
has ever been translated into German." (Leonard Tramiel)
https://www.atarimagazines.com/startv3n1/threeyearsofst.php