Re: REPACK: warn about skipping foreign partitions

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Antonin Houska <ah(at)cybertec(dot)at>
Subject: Re: REPACK: warn about skipping foreign partitions
Date: 2026-09-25 13:39:07
Message-ID: CAGRkXqT4-X1_4WMx+V9MA_69pM_fGrUhst7EhR5YwPD9kUoeTA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Zsolt,

A few small things.

In the non index case the new find_all_inheritors call returns the
same list as the one right below it. You could reuse it there.

For the docs I would write "are skipped with a warning".

The last test, the parent with only foreign partitions, goes through
the same code path as the one before it. I would drop it.

Otherwise it looks good to me.

Thanks
Shihao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Viktor Holmberg 2026-09-25 13:52:08 Re: ON CONFLICT DO SELECT returns rows hidden by a view
Previous Message shihao zhong 2026-09-25 13:37:06 Re: [PATCH] add missed tests for gist index