| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PG19] Indexes from 18 miss rows after pg_upgrade |
| Date: | 2026-10-22 03:39:15 |
| Message-ID: | CAGRkXqT0w==YWBD3yRpDyfHfFQ8OnnOT2=SzbcB2=g=AEPtP2A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Andreas,
> we have so far never added anything to check.c in pg_upgrade for a
> case like this.
There is one. In 18, check_for_unicode_update() (b81ffa13e35) warns
about indexes on lower(), upper(), regexp and normalize() in builtin
databases when the Unicode version changes. It fires on 18 to 19 in my
test. So pg_upgrade warns about a lower() index, and says nothing
about a text search index in the same kind of database that misses
rows for any accented word.
My patch only adds more functions to that same idea. Jeff, since you
wrote that check, what do you think? If the answer is release notes,
I am fine with that, and I can draft the text, including the stemmer
languages that changed.
Thanks,
Shihao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-10-22 03:46:05 | Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically |
| Previous Message | shihao zhong | 2026-10-22 03:29:38 | Re: [PG19] Promotion hangs behind a backend blocked on a stuck client |